Feature: PWA #479
Merged
Feature: PWA #479
+266
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add web app manifest with icons and theme configuration - Add service worker with cache-first strategy for static assets - Add useServiceWorker hook for SW registration - Add PWA meta tags and Apple-specific tags to index.html - Update vite.config.ts for optimal asset caching
Collaborator
|
Oh, we are so grateful to you. We will audit this PR request as soon as possible. |
Member
|
LGTM. I dont know much about PWA's so thanks for doing it for me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Short summary of what this PR does
Changes Made
I decided not to use any npm packages such as vite-plugin-pwa or others because, with the recent attacks on packages, I thought it would be better to have control, also because it is a feature that needs few additions and can always be improved.
Tips
This actually works only if web app is served under https with valid certificate like let's encrypt ones.
Screenshots / Demos
Without PWA
no-pwa.mp4
With PWA
with-pwa.mp4
Checklist