Conversation
`CSI > Ps m` (XTMODKEYS, used to enable modifyOtherKeys) and `CSI ? Ps m` reached the SGR handler with the prefix dropped, so `ESC[>4m` was executed as SGR 4 and switched underline on for everything printed afterwards. Return early from the SGR handler when the sequence has a prefix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CSI > Ps m(XTMODKEYS, used to enable modifyOtherKeys) andCSI ? Ps mreach the SGR handler with the prefix discarded.ESC[>4mis therefore executed as SGR 4, which turns underline on for everything printed afterwards.Programs that request modifyOtherKeys at startup trigger this. In my case Claude Code (a TUI) renders fully underlined, including blank cells, and the underline never clears.
This returns early from the SGR handler when the sequence has a prefix. Tests cover
>,?and plainESC[4m, so SGR itself still works.