Repository navigation
Conversation
ShlomiPorush
added a commit
to Tildeck/tildeck
that referenced
this pull request
Sep 30, 2026
## What Shlomi reported that on Windows the terminal connected but accepted no typing. - Cause: xterm 4.0.0 opens its keyboard connection (`TextInput.setClient`) without a view id. Flutter's Windows embedder rejects that since 3.44, and the terminal then drops every typed character. The fix is known upstream (TerminalStudio/xterm.dart#224, #228, #231) but was never merged or released. - Fix: the app depends on a copy of xterm 4.0.0 in `app/third_party/xterm` with the one-line patch; `PATCHES.md` records it and when to drop the copy. ## Verification - `app/test/terminal_input_test.dart` checks the configuration sent to the platform: it failed before the patch (`viewId` null) and passes after. - `app/test/terminal_typing_test.dart` fills in the connection form, connects to the throwaway OpenSSH server, trusts its key, types a command, and sees it run. - `scripts/verify.sh --area app` passes (28 tests, debug APK); `scripts/windows.ps1 build` passes. ## Not verified here Typing in the real Windows window: the automation session cannot send keystrokes to it. Shlomi confirms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Windows IME input for
CustomTextEditby passing the current FlutterviewIdintoTextInputConfiguration.Problem
On Windows,
TextInput.setClientcan fail with:PlatformException(Bad Arguments, Could not set client, view ID is null.)When that happens, IME text input (for example Chinese input) does not work.
Change
Add:
Validation
Tested on Flutter Windows desktop: