Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rendering): fix bloom not working #78

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

Imitater967
Copy link
Contributor

@Imitater967 Imitater967 commented Mar 30, 2024

The bloom is not working because there is something wrong with high pass node.

BloomWorkFlow:

  1. Blur scene color: Working fine
  2. extract high color: Error : the intensity is usually not strong enough(less than 1)
//here should be a minus "-" instead of a multiply "*" because we want color higher than threshold to be collected
if(relativeLuminance * highPassThreshold > 1.0) {
        outColor.rgba = vec4(color.rgb, 1);
    } else {
        outColor.rgba = vec4(0);
    }
  1. change the shader
  2. finished

@jdrueckert
Copy link
Member

Gave it a go and there's definitely an effect now when you enable bloom, but it's a bit too extreme 😅

Bloom disabled:
image

Bloom enabled:
image

@Imitater967
Copy link
Contributor Author

image
I'll make this final, if scale up the intensity the torch would look nice though, but the snow will be too bright, I tried change Exposure node, but it just make whole graphic looks worse, the best approach might be add emission map for torch

Copy link
Member

@jdrueckert jdrueckert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that tests out fine. If we get complaints that something is too bright, we can tweak the numbers some more, but for now, this fixes the bloom so let's merge it

@jdrueckert jdrueckert merged commit b84fcfb into Terasology:develop Apr 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants