refactor: use EntityBuilder for creating test character #97
Conversation
jdrueckert
added
Category: Test/QA
| moveComponent.movementTypes.addAll(Sets.newHashSet(movementTypes)); | ||
| return moveComponent; | ||
| }); | ||
| builder.updateComponent(CharacterMovementComponent.class, characterMovement -> { |
There was a problem hiding this comment.
I wonder whether we should use upsertComponent all the time, or at least log something if the component is not present? 🤔 Should updateComponent itself log something (DEBUG level?) if the component is not present?
The main drawback of using updateComponent is that it will silently do nothing if the component is not present. So, upsertComponent is the safe bet to ensure the right thing will happen, while updateComponent is a bit nicer to read if you're pretty certain that the component will be present...
There was a problem hiding this comment.
Not sure whether I would encourage using updateComponent only because it's more readable but in some cases doesn't do what I want it to do based on an assumption I had that might have changed by now...
I guess upsertComponent might indeed be better here.
skaldarnar
deleted the
refactor/use-entitybuilder-for-testcharacter-creation
branch
- style: format `.behavior` files - chore: add TODO ideas and questions in several places - chore: add some debug logging - feature/fix: small adjustments to Behaviors logic Follow-up PR to #89. Related PRs (extracted from this): #94, #96, #97, #99. Contributes to MovingBlocks/Terasology#4981. Depends on Terasology/FlexiblePathfinding#26 and Terasology/FlexiblePathfinding#27.
Extracted from #92