Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorporated review comments for flood proximity #378

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

nupur-lal
Copy link
Collaborator

Most of the points/zone etc not showing on the map was due to the subset of data I created. Created new subset of 60k records in the flood zone 7.
Other comments/explanations added in the notebook.

Copy link
Collaborator

@DougEbel DougEbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first map in 2.3 says you are putting flood zones on a map but all I see is a map with some sort of outline in the ocean. Are those the flood zones you are talking about?

Maps in 2.6 and 3.2 look identical.

All maps need text after (or before) that explain what the map means and encourage the user to click/zoom/etc to understand what you say it means.

All maps should have similar sizes. when we get to 3.6 and 3.7, the maps are short.

Copy link
Collaborator

@DougEbel DougEbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clarified that most of the demo starting with 3 was focused on zone 7. I updated some explanations after maps. On the last map, I changed the .3 color from lime to green because lime dots don't show up on the map background.

There are some performance issues, especially when finding the addresses within the centroid of zone 7. I don't have the syntax in front of me, but the idea is to pre-filter the addresses based on whether that address falls within the MBR (minimum bounding rectangle) of the desired zone. Determining if points fall within a geospatial shape requires lots of calculations. The MBR has the min/max of the x & y so that the basic filtering can be done with 2 BETWEEN constraints. For those passing that test, the more sophisticated point inside shape can be determined.

@DougEbel DougEbel merged commit 298906e into main Aug 30, 2023
@DougEbel DougEbel deleted the flood_proximity branch August 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants