Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(user-menu): fixed styles for user menu profile #2259

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

owilliams320
Copy link
Collaborator

Description

Style adjustments for the user menu profile component

What's included?

  • Reduced all previous styles no longer needed since angular material update
  • Updated angular demo for user profile component

Test Steps

  • npm run start
  • then go to Componets -> User profile
  • finally test the examples

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Before

Screenshot 2024-10-14 at 6 17 43 PM

Fixed

Screenshot 2024-10-14 at 6 13 15 PM
Screenshot 2024-10-14 at 6 13 29 PM

Copy link
Collaborator

@bsahitya bsahitya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@owilliams320 owilliams320 merged commit 242fff0 into main Oct 17, 2024
6 checks passed
@owilliams320 owilliams320 deleted the fix/user-profile-styles branch October 17, 2024 20:09
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants