Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): background styles to selected nav item #2199

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

owilliams320
Copy link
Collaborator

Description

Adding styles for a nav item that has the child item selected

What's included?

  • Nav item parent styling when child is selected

Test Steps

  • npm run storybook
  • then go to app shell story
  • finally click item with subnav paretn

General Tests for Every PR

  • npm run start still works.
  • npm run lint passes.
  • npm run stylelint passes.
  • npm test passes and code coverage is not lower.
  • npm run build still works.
Screenshots or link to StackBlitz/Plunker

Screenshot 2024-07-23 at 1 01 17 PM
Screenshot 2024-07-23 at 1 01 23 PM

Copy link
Collaborator

@adamnel adamnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

@adamnel adamnel merged commit dc64034 into main Jul 23, 2024
7 checks passed
@adamnel adamnel deleted the style/nav-item-selected branch July 23, 2024 17:24
@owilliams320
Copy link
Collaborator Author

🎉 This PR is included in version 8.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants