Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ—οΈ Migrate linters to ruff #944

Merged
merged 21 commits into from
Jan 14, 2023
Merged

Conversation

TeoZosa
Copy link
Owner

@TeoZosa TeoZosa commented Jan 14, 2023

WHAT

cookiecutter

Adds ruff as a pre-commit hook and migrates the below existing linters:

  • isort
  • Pylint
  • McCabe
  • Pyflakes
  • pycodestyle
  • FlakeHeaven
  • pyupgrade

Project Template

Adds ruff and nbqa-ruff as a pre-commit hook and migrates the below existing linters:

  • isort
  • Pylint
  • McCabe
  • Pyflakes
  • pycodestyle
  • FlakeHeaven
  • pyupgrade
  • nbqa-isort
  • nbqa-pylint
  • nbqa-pyupgrade

WHY

To significantly reduce linting time for the above-mentioned linters (11.24s => 0.04s) and automate more fixes.

@TeoZosa TeoZosa self-assigned this Jan 14, 2023
@TeoZosa TeoZosa marked this pull request as ready for review January 14, 2023 08:26
@TeoZosa TeoZosa added enhancement New feature or request ci Changes to CI configuration files and scripts cookiecutter Changes outside of the template directory dependencies Pull requests that update a dependency file labels Jan 14, 2023
@TeoZosa TeoZosa merged commit e43e5a9 into master Jan 14, 2023
@TeoZosa TeoZosa deleted the ci/migrate-linters-to-ruff branch January 14, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI configuration files and scripts cookiecutter Changes outside of the template directory dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant