👷 Remove Dependabot-triggered workflows #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeoZosa
added
ci
TeoZosa
force-pushed
the
ci/migrate-to-dependabot-secrets
branch
3 times, most recently
from
0288ef6
to
f8fe89d
Compare
TeoZosa
force-pushed
the
ci/migrate-to-dependabot-secrets
branch
2 times, most recently
from
2c5af74
to
208b5f1
Compare
TeoZosa
force-pushed
the
ci/migrate-to-dependabot-secrets
branch
from
208b5f1
to
efb74c9
Compare
Previously used to resolve issues with Dependabot's inability to access repo secrets. This was rectified by the addition of Dependabot secrets as a GitHub-native feature. - see https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-encrypted-secrets-for-dependabot
Previously used to resolve issues with Dependabot's inability to access repo secrets. This was rectified by the addition of Dependabot secrets as a GitHub-native feature. - see https://docs.github.com/en/code-security/dependabot/working-with-dependabot/managing-encrypted-secrets-for-dependabot
Fixing checkouts on branches which weren't properly parsed by the previous string processing logic. see: - https://stackoverflow.com/a/69220229/6470891 - https://stackoverflow.com/questions/58033366/how-to-get-the-current-branch-within-github-actions#comment123798199_58034787
To fix long-running Windows benchmarks failing CI.
TeoZosa
force-pushed
the
ci/migrate-to-dependabot-secrets
branch
from
efb74c9
to
a3e5f86
Compare
TeoZosa
added a commit
that referenced
this pull request
Dec 14, 2022
Benchmarks publishing broken since #598.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Release,Publish ADR Documentation via Log4brains, &Reset Instance(in the meta-project) workflows to commits/PRsPublish Performance Testing Benchmarksworkflow to commits/PRsWhy
Dependabot was previously unable to access repo secrets. This was rectified by (a) the introduction of a permissions key which Dependabot now honors, and (b) the addition of Dependabot secrets as a GitHub-native feature. This will now make CI more robust since workflows no longer run need to be launched in isolation, which also reduces unnecessary duplicate workflow runs for developer (non-Dependabot)-triggered workflows, and are coupled to triggered commits/PRs for review.
References