This repository was archived by the owner on Nov 27, 2024. It is now read-only.
Added Async suffix to any methods that returned a Task or Task<> and … #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…did not have one.
|
Nice, thanks for the contribution |
|
Just merged this in and it broke the unit test, I should have checked first, my bad Are you able to update the UnitTest call to the May have to load the OnnxStackCore.sln |
|
Done. did not even notice they where there. |
|
Yeah was just added yesterday and I already forgot, lol |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed there's some inconsistencies with naming convention, fixed the async ones.