Create tendrl_definitions_add_object_listing_key.adoc #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tendrl_definitions_add_object_listing_key
tendrl_definitions_add_object_listing_key
Contributor
Author
|
@Tendrl/tendrl-core , @shtripat @anivargi @nnDarshan @anmolbabu @GowthamShanmugam please review |
|
Is this specification connected with future specification for tendrl-api for listing objects in etcd? |
shtripat
reviewed
Dec 5, 2016
| * Adds "list" key to all Objects in Tendrl namespaces | ||
|
|
||
| * The "list" key will point to a relative path in the central store which will contain list of all instances of that object | ||
| eg: 'clusters/xyz/objects/Volumes/' will contain list of all Volumes in that cluster |
Member
There was a problem hiding this comment.
Shouldnt it be like /clusters//Volumes rather?
Contributor
There was a problem hiding this comment.
Ideally it should be /clusters/:cluster_id/volumes, but whatever you put here will be used for listing from the API
This was referenced Dec 6, 2016
Contributor
Author
|
@anivargi any queries on this? I am going to merge this today |
Contributor
|
@r0h4n No. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tendrl_definitions_add_object_listing_key