Skip to content

Conversation

@HunterXuan
Copy link

@HunterXuan HunterXuan commented Dec 1, 2023

According to the docs of yauzl (see here):

If close() is never called, then the zipfile is "kept open". For zipfiles created with fromFd(), this will leave the fd open, which may be desirable. For zipfiles created with open(), this will leave the underlying fd open, thereby "leaking" it, which is probably undesirable. For zipfiles created with fromRandomAccessReader(), the reader's close() method will never be called. For zipfiles created with fromBuffer(), the close() function has no effect whether called or not.

We are using this lib in our application, and found the "leaking problems", which is likely caused by the unclose zipFile object.

@HunterXuan
Copy link
Author

@xiaoyuze88

@HunterXuan HunterXuan closed this Dec 5, 2023
@HunterXuan HunterXuan reopened this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant