fix(sdk-py): reject malformed falsey response data - #1243
Open
MohammedThowfiq wants to merge 1 commit into
Open
Conversation
Signed-off-by: Mohammedthowfiq <49336054+MohammedThowfiq@users.noreply.github.com>
Collaborator
|
Thank you so much for your attention and contribution! We will arrange an internal review for this PR shortly, and all feedback will be shared right here in the discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Python v3 transport promises object-valued response data, but
envelope.get("data") or {}converts[],false,0, and""into a successful empty result before checking their types. This hides malformed server responses from both synchronous and asynchronous SDK callers.Only missing or null data now defaults to an empty object. Other non-object values raise the existing
TDAMErrorwith the response trace ID. Object payloads and optional data retain their existing behavior.Verification
From
sdk/memory-core/python/, using Python 3.12.13 and httpx 0.28.1:python -m unittest discover -s tests -v— 2 tests passed, covering 24 synchronous/asynchronous subcases. Before the fix, the 8 falsey-data cases failed because no exception was raised.python -m build— source distribution and wheel built successfully.git diff --check— passed.Tests use
httpx.MockTransportand make no external requests. This change is confined to v3 response decoding; v2 behavior is unchanged.