feat：文件类型变量上传的文件支持版本管理 #11467 #11482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 30681
useryuyu
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
…o issue_11467 # Reviewed, transaction id: 31521
# Reviewed, transaction id: 31544
# Reviewed, transaction id: 31625
lockiechen
reviewed
Mar 10, 2025
| extractRandomString (path) { | ||
| const RANDOM_STRING_REGEX = /\/([A-Za-z0-9]{8})\// | ||
| const match = path.match(RANDOM_STRING_REGEX) | ||
| return match ? match[1] : null |
| } | ||
| this.updatePath() | ||
| }, | ||
| generateUniqueRandomString (existingStrings, length = 8) { |
There was a problem hiding this comment.
有randomString这个方法，在utils里面不用自己写
|
|
||
| if (this.enableVersionControl) { | ||
| const uniqueStrings = new Set() | ||
| this.fileDefaultVal.randomFilePath = this.generateUniqueRandomString(uniqueStrings) |
There was a problem hiding this comment.
你这里判断每次都给个新的Set, 意义是什么？
# Reviewed, transaction id: 33316
# Reviewed, transaction id: 33320
# Reviewed, transaction id: 33891
|
|
# Reviewed, transaction id: 34104
# Reviewed, transaction id: 34142
# Reviewed, transaction id: 34448
# Reviewed, transaction id: 34504
lockiechen
reviewed
Mar 18, 2025
| handler () { | ||
| this.splitFilePath() | ||
| }, | ||
| handler: 'splitFilePath', |
There was a problem hiding this comment.
handler: funciton (newValue) {
this.enableVersionControl = this.versionControl
const lastSlashIndex = newValue.lastIndexOf('/')
this.fileDefaultVal.fileName = newValue.slice(lastSlashIndex + 1)
const randomFile = this.extractRandomString(newValue)
if (this.enableVersionControl && randomFile) {
const lastIndex = newValue.lastIndexOf('/', lastSlashIndex - 1)
this.fileDefaultVal.randomFilePath = randomFile
this.fileDefaultVal.directory = newValue.slice(0, lastIndex)
} else {
this.fileDefaultVal.directory = newValue.slice(0, lastSlashIndex)
}
},
| uploadFileName: '' | ||
| directory: '', | ||
| fileName: '', | ||
| randomFilePath: that.randomSubPath |
There was a problem hiding this comment.
不需要再去维护一份randomFilePath数据了， 还有，that没意义，直接用this一样的
| handler () { | ||
| this.splitFilePath() | ||
| handler: function (newValue) { | ||
| const currentValue = newValue.directory ?? newValue |
There was a problem hiding this comment.
外层已经有处理数据了这里的value就不会是object了
| this.fileName = currentValue.slice(lastSlashIndex + 1) | ||
|
|
||
| if (this.enableVersionControl && this.randomFilePath) { | ||
| this.randomFilePath = this.randomSubPath |
There was a problem hiding this comment.
这一行可以不要，不需要再在里面维护一个randomFilePath
| this.randomFilePath = '' | ||
| } | ||
| this.handleChange('enableVersionControl', value) | ||
| this.updatePath('enableVersionControl', value) |
There was a problem hiding this comment.
这里不需要再这么写呀，直接把外层的randomSubPath更新一下就可以
# Reviewed, transaction id: 34634
lockiechen
reviewed
Mar 18, 2025
| handleEnableVersionControl (value) { | ||
| if (!this.flex && !value) { | ||
| this.handleChange('randomStringInPath', '') | ||
| } |
There was a problem hiding this comment.
统一在updatePath里面做这个就行了，不需要再在这里多弄一个
|
|
||
| const path = [ | ||
| this.directory, | ||
| ...(randomFilePath ? [randomFilePath] : []), |
There was a problem hiding this comment.
这里应该是以this.enableVersionControl为判断条件的
| let randomFilePath = this.randomSubPath | ||
| if (newFile && this.enableVersionControl) { | ||
| randomFilePath = randomString(8) | ||
| } |
There was a problem hiding this comment.
this[name] = value
let randomFilePath = this.enableVersionControl ? this.randomSubPath : ''
# Reviewed, transaction id: 34660
lockiechen
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11467