perf:优化插件管理菜单默认插件查询 #11142 #11144
Merged
perf:优化插件管理菜单默认插件查询 #11142 #11144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjieliang
requested review from
irwinsun,
mingshewhe,
stubenhuang,
royalhuang,
randychen2046 and
tangruotian
as code owners
carlyin0801
reviewed
Oct 28, 2024
| conditions.add(tspr.PROJECT_CODE.eq(projectCode).and(tspr.STORE_TYPE.eq(0))) | ||
| } else { | ||
| conditions.add( | ||
| ta.ID.`in`(defaultAtomIds) |
There was a problem hiding this comment.
逻辑写得有问题，默认插件无需安装，不需要关联T_STORE_PROJECT_REL
carlyin0801
reviewed
Oct 30, 2024
| installType == StoreProjectTypeEnum.INIT.type.toByte() || | ||
| installType == StoreProjectTypeEnum.TEST.type.toByte() | ||
| } | ||
| if (default) { |
| installTime = DateTimeUtil.toDateTime(it[KEY_INSTALL_TIME] as LocalDateTime), | ||
| installType = StoreProjectTypeEnum.getProjectType((it[KEY_INSTALL_TYPE] as Byte).toInt()), | ||
| installer = installer, | ||
| installTime = if (default) { |
There was a problem hiding this comment.
这个默认插件的安装时间用更新时间有点奇怪，需要找产品确认下
| var limit = pageSize | ||
| var offset = 0 | ||
| if ((page -1) * pageSize - projectCount > 0) { | ||
| offset = (page - 1) * pageSize- projectCount |
There was a problem hiding this comment.
这逻辑有问题吧，临界页面offset不是0开始，limit也不是pageSize吧
| /** | ||
| * 获取默认插件 | ||
| */ | ||
| fun getDefaultAtoms( |
There was a problem hiding this comment.
service把普通插件和默认插件分开处理，但dao的逻辑差不多，看能不能合并，通过标识字段来区分逻辑差异
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perf:优化插件管理菜单默认插件查询 #11142