feat：流水线变量语法支持两种风格 #10576 #10885
Merged
feat：流水线变量语法支持两种风格 #10576 #10885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Reviewed, transaction id: 15341
# Reviewed, transaction id: 15875
# Reviewed, transaction id: 16284
# Reviewed, transaction id: 16330
# Reviewed, transaction id: 16388
# Reviewed, transaction id: 16545
useryuyu
requested review from
lockiechen,
terlinhe and
zhanxu33
as code owners
…o issue_10576 # Reviewed, transaction id: 16722
# Reviewed, transaction id: 16875
# Reviewed, transaction id: 16998
# Reviewed, transaction id: 17780
useryuyu
force-pushed
the
issue_10576
branch
from
ee9334f
to
cb44498
Compare
…o issue_10576 # Reviewed, transaction id: 17783
# Reviewed, transaction id: 17790
…o issue_10576 # Reviewed, transaction id: 18626
# Reviewed, transaction id: 18627
# Reviewed, transaction id: 19193
# Reviewed, transaction id: 19200
…o issue_10576 # Reviewed, transaction id: 19919
# Reviewed, transaction id: 19947
# Reviewed, transaction id: 20185
# Reviewed, transaction id: 20245
lockiechen
approved these changes
Oct 12, 2024
| const pipelineDialectMap = { | ||
| 'CLASSIC': t('传统风格'), | ||
| 'CONSTRAINED': t('制约风格'), | ||
| } |
There was a problem hiding this comment.
这个可以做为一个公共的常量配置，我看挺多地方会用到的，比如下面这个，后续的话如果改到也好维护，国际化翻译方面，也可以直接用这两个常量CLASSIC，CONSTRAINED用Key就行
| namingStyle: { | ||
| CLASSIC: this.$t('traditionalStyle'), | ||
| CONSTRAINED: this.$t('constraintStyle') | ||
| } |
There was a problem hiding this comment.
这里用的又是不同的国际化key，但是内容是一样的
# Reviewed, transaction id: 20411
# Reviewed, transaction id: 20420
# Reviewed, transaction id: 20950
# Reviewed, transaction id: 20976
# Reviewed, transaction id: 20981
# Reviewed, transaction id: 21034
# Reviewed, transaction id: 21042
# Reviewed, transaction id: 21159
# Reviewed, transaction id: 21382
…o issue_10576 # Reviewed, transaction id: 21385
# Reviewed, transaction id: 21386
# Reviewed, transaction id: 21441
…o issue_10576 # Reviewed, transaction id: 22284
# Reviewed, transaction id: 22288
# Reviewed, transaction id: 22309
# Reviewed, transaction id: 22340
# Reviewed, transaction id: 22362
# Reviewed, transaction id: 22398
# Reviewed, transaction id: 22413
…o issue_10576 # Reviewed, transaction id: 22718
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10576