Fix basicsr losses import #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBear
added a commit
to AdamBear/GFPGAN
that referenced
this pull request
Aug 17, 2022
…t compatible with basicsr 1.3.5, so need also to modify requirements.txt.
Closed
AdamBear
added a commit
to AdamBear/GFPGAN
that referenced
this pull request
Aug 17, 2022
This reverts commit 7d657f2
humayun
pushed a commit
to PhotoDay/GFPGAN
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the most recent 1.4.0 release of BasicSR (https://github.com/XPixelGroup/BasicSR/releases), some basicSR module imports in GFPGAN may have to be reconfigured as some of the changes include updates to some directories such as the basicsr.losses directory.
The only error I came across was in the gfpgan_model.py module, where I had to change "from basicsr.losses.losses import r1_penalty" to "from basicsr.losses.gan_loss import r1_penalty". This was the only import error that occurred during execution of my script but there may be several other module imports that may have to be double checked.