-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
支持capture事件 #839
Merged
Merged
支持capture事件 #839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
建议补充一下文档 |
@Gcaufy 已经补充文档和测试用例 |
Gcaufy
approved these changes
Jan 31, 2018
cool, thanks. |
@Gcaufy |
@milkmeowo 感谢 但在组件中使用 @touchstart.capture="handler" 有点问题,没有转换handler到组件自己的方法 急着用,翻了半天源码还没找到,不知道在哪个文件中处理这部分的? |
ok,找到了,我去递交patch Index: packages/wepy-cli/src/compile-template.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- packages/wepy-cli/src/compile-template.js (revision b8d11089f74e7cefc3eaf33e5d2e0de3456197c1)
+++ packages/wepy-cli/src/compile-template.js (date 1520155583928)
@@ -283,7 +283,7 @@
}
// bindtap="abc" => bindtap="prefix_abc"
if (
- (config.output !== 'ant' && (attr.name.indexOf('bind') === 0 || attr.name.indexOf('catch') === 0)) ||
+ (config.output !== 'ant' && (attr.name.indexOf('bind') === 0 || attr.name.indexOf('catch') === 0 || attr.name.indexOf('capture') === 0)) ||
(config.output === 'ant' && (attr.name.indexOf('on') === 0 || attr.name.indexOf('catch') === 0))
) {
// added index for all events; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run test
passesfix #542
支持
@tap.capture
和@tap.capture.stop
的语法