Repository navigation
ci(codex-review): pin codex-action to v1.11 and cap review job runtime - #640
Merged
Merged
Conversation
openai/codex-action@v1 now resolves to v1.12+, which rewrote the codex-exec runner to wait on the whole process tree's stdio. The backgrounded Responses API proxy keeps those descriptors open, so the step never sees stdio close and hangs until timeout — the review is produced (final-message is printed) but the job idles for hours and the Post-comment step never runs, so the review is thrown away. Pin to v1.11, the last release before the regression (identical final-message output contract), and add timeout-minutes: 15 to the review job so any future hang is capped instead of idling for the default 6h. Refs: openai/codex-action#151, openai/codex#9269
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Codex review job hangs indefinitely and never posts its comment, even though the review completes. Example: run 35328364012 produced a full
**Findings**output in the logs (tokens used 131,234), then idled inRun Codex reviewfor ~3 hours until GitHub's default timeout killed the job — so thePost review as PR commentstep never ran and the review was thrown away.Root cause
openai/codex-action@v1now resolves to v1.12+, which introduced a regression: v1.12 rewrote thecodex-execrunner to wait on the whole process tree's stdio. The backgrounded Responses API proxy the action starts keeps those file descriptors open, so the step never observes stdio close and hangs until timeout even after the model has finished and printed its final message.Fix
openai/codex-action@v1.11— the last release before the regression. Itsfinal-messageoutput contract is identical to v1.12, so the comment-posting step is unaffected, and the bubblewrap userns fix that was actually needed landed back in v1.6.timeout-minutes: 15to thereviewjob. A normal review finishes in ~2 min; this caps any future hang instead of letting it idle for the default 6h and burn runner minutes.Test plan
This is a CI-only workflow change (YAML), not touched by the CLI end-to-end suite. Verified:
openai/codex-actionv1.11 tag exists (git ls-remote→7c168a2… refs/tags/v1.11).review.timeout-minutes == 15, codex stepuses == openai/codex-action@v1.11.codex-review-on-assign.yml; no other files or docs reference the action version.