Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

优化展示用户名,而不是固定为Tencent #485

Merged
merged 4 commits into from
May 8, 2023
Merged

优化展示用户名,而不是固定为Tencent #485

merged 4 commits into from
May 8, 2023

Conversation

SpringHgui
Copy link
Contributor

@SpringHgui SpringHgui commented May 8, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

修改前:固定为Tencent
image
修改后:动态根据实际用户名展示
image

@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

完成

@uyarn
Copy link
Collaborator

uyarn commented May 8, 2023

@SpringHgui
Copy link
Contributor Author

Copy link
Collaborator

@timi137137 timi137137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我建议你把 src/store/modules/user.ts 里的td_main改成Tencent,在预览网页上显示其他名称不太合适

@SpringHgui
Copy link
Contributor Author

我建议你把 src/store/modules/user.ts 里的td_main改成Tencent,在预览网页上显示其他名称不太合适

修改了

@uyarn uyarn merged commit 2794bdc into Tencent:develop May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants