Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 将现有代码迁移至Typescript严格模式 #429

Closed
wants to merge 4 commits into from

Conversation

timi137137
Copy link
Collaborator

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • feat: 将现有代码迁移至Typescript严格模式

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@timi137137 timi137137 requested a review from uyarn February 20, 2023 15:36
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

完成

@timi137137
Copy link
Collaborator Author

image
image
我想修,但是我复现不了

@waney
Copy link

waney commented Mar 20, 2023

加油!

@timi137137 timi137137 mentioned this pull request Apr 6, 2023
16 tasks
</template>
</t-avatar>
</template>
<template #status>
<t-tag :theme="product.isSetup ? 'success' : 'default'" :disabled="!product.isSetup">{{
product.isSetup ? '已启用' : '已停用'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还有一个疑问 template里面都加props是常规做法吗?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还有一个疑问 template里面都加props是常规做法吗?

好问题我也不清楚,不过这么写是能最大程度简化代码,并且也不存在理解困难

@timi137137
Copy link
Collaborator Author

此pr暂时关闭,拆分为三个PR重新迁移

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants