-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 将现有代码迁移至Typescript严格模式 #429
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4ae416
to
88ac0e0
Compare
加油! |
uyarn
reviewed
Apr 12, 2023
</template> | ||
</t-avatar> | ||
</template> | ||
<template #status> | ||
<t-tag :theme="product.isSetup ? 'success' : 'default'" :disabled="!product.isSetup">{{ | ||
product.isSetup ? '已启用' : '已停用' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还有一个疑问 template里面都加props是常规做法吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里还有一个疑问 template里面都加props是常规做法吗?
好问题我也不清楚,不过这么写是能最大程度简化代码,并且也不存在理解困难
此pr暂时关闭,拆分为三个PR重新迁移 |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是?
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat: 将现有代码迁移至Typescript严格模式
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单