Skip to content

fix(Radio): add null check for inputNode in keyboard event handler #3906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
uyarn merged 2 commits into from
Oct 23, 2025
Merged

fix(Radio): add null check for inputNode in keyboard event handler #3906

uyarn merged 2 commits into from
Oct 23, 2025

Conversation

@RylanBot
Copy link
Collaborator

@RylanBot RylanBot commented Oct 23, 2025 •
edited
Loading

🤔 这个 PR 的性质是？

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

复现步骤：

  • 选中某个 Radio 后（焦点落在组件内部的 <span>，而不是 <input> 本身）
  • 按下 Enter 键
  • 报错

（原先的 Enter 应该是为了配合 Tab 键盘操作的...手动选中也不需要）

📝 更新日志

  • fix(RadioGroup): 修复键盘操作时读取到 null 产生的报错

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025 •
edited
Loading

tdesign-react-demo

npm i https://pkg.pr.new/tdesign-react@3906

commit: b9a990e

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025 •
edited
Loading

完成

@uyarn uyarn merged commit c1a1e32 into develop Oct 23, 2025
9 checks passed
@uyarn uyarn deleted the rylan/fix/radio branch October 23, 2025 16:29
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uyarn uyarn uyarn approved these changes

@HaixingOoO HaixingOoO HaixingOoO approved these changes

@honkinglin honkinglin Awaiting requested review from honkinglin honkinglin is a code owner

@carolin913 carolin913 Awaiting requested review from carolin913 carolin913 is a code owner

@NWYLZW NWYLZW Awaiting requested review from NWYLZW NWYLZW is a code owner

@ZWkang ZWkang Awaiting requested review from ZWkang ZWkang is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@RylanBot @uyarn @HaixingOoO