Skip to content

Conversation

@vancece
Copy link
Contributor

@vancece vancece commented Sep 8, 2025

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#697

💡 需求背景和解决方案

  1. 增加 Message 组件单元测试
  2. 修复 Message 组件问题
image

📝 更新日志

  • feat(Message): add unit test and fix problems
  • 修复 Message marquee 参数配置不生效,表现异常
  • 修复 Message closeBtn 表现异常
  • 修复 Message Click 事件 event 出参不按照文档结构
  • 修复 Message Link 表现异常
  • 增加 Message marquee 动画 hooks useMarqueeAnimation

⚠️ breaking change

  • Click 事件出参结构重新更改

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

本次发现问题 ⚠️ 需要 PM 解决,均已添加 Todo

  • Message 组件入参 Link 参数 ts 描述有问题,使用 Link 参数,校验不通过(单元测试已注释)
  • Message 组件入参 zIndex 根据文档描述应该默认为 5000(单元测试已注释)

Copy link
Contributor Author

@vancece vancece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

@novlan1 novlan1 merged commit fd8ee86 into Tencent:develop Sep 12, 2025
1 check passed
anlyyao added a commit that referenced this pull request Sep 22, 2025
* chore: update group code path (#759)

* Update image source for user group QR code

* Fix image source for user group in README

Updated image source for user group in README.

* test(layout): optimized the unit tests for the layout component (#749)

* test(divider): merged test cases for the divider component and optimized

Merged the original two test files into one, removed duplicates, and optimized the format.

fix #697

* test(divider): standardize divider test cases

standardize Divider test cases

fix #697

* test(divider): removed some unnecessary snapshots

- Align, layout, dashed assertions: no snapshot storage (verify CSS classes).

fix #697

* test(layout): optimized the unit tests for the layout component

- Merged multiple test files and optimized the test cases

fix #697

* fix(steps): inconsistent rendering between string and number when the props of 'current' is a string (#761)

- Character conversion when the props of 'current' is a string

* test(drawer): add unit test (#767)

* test(drawer): add unit test

* chore: update snapshot

* fix: fix cr

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: anlyyao <anly_yaw@163.com>

* test(steps): optimized the unit tests for the steps component (#765)

- Merged duplicate test cases and added supplementary ones, achieving 100% coverage.

fix #697

* test(component): add test case of stepper (#763)

* test(component): add test case of stepper

* fix: fix cr

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* test(pull-down-refresh): add pull-down-refresh test (#774)

* test(pull-down-refresh): add pull-down-refresh test

* test(pull-down-refresh): improve coverage

* test(pull-down-refresh): improve code and add coverage

* test(pull-down-refresh): improve hooks test

* test(pull-down-refresh): improve test coverage

* fix(PullDownRefresh): fix change event always being triggered twice

* chore: update demo

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* test(DropdownMenu): add test (#762)

* test(DropdownMenu): add test

* test: refactor code structure for improved readability and maintainability

* chore: update snapshot

* test(DropdownMenu): enhance tests for custom options and rendering behavior

* test(DropdownItem): add comprehensive tests for DropdownItem component functionality

* test: improve test coverage for dropdownMenu

* test(dropdown-menu): add clickaway behavior tests for DropdownItem and enhance existing tests

* test: update dropdownMenu test coverage to 100%

* test: remove snapshot tests for DropdownItem and DropdownMenu

* test(dropdown-item): simplify style check by asserting style attribute is null

* test(dropdown-item): simplify style check by removing unnecessary null check

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* 更新`Image`组件示例对齐 (#769)

* fix(image): update Image component examples

* fix(image): update unit test

* chore: formatting unit test files

* chore: update demo

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* test(table): add table test (#751)

* test: (table): add table test

* test: add table test case

* test(cell): add cell test (#737)

* test(cell): add cell test

* chore: formatting unit test files

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* test(Qrcode): add qrcode's unit test (#731)

* test(Qrcode): add qrcode's unit test

* fix: resolve conflicts

---------

Co-authored-by: anlyyao <anly_yaw@163.com>

* feat(test): 新增 Rate 相关组件测试,优化提示框逻辑与安全访问 (#754)

* feat(test): 新增 Rate 相关组件测试,优化提示框逻辑与安全访问

* test: 移除 Rate 组件拖拽时 Tips 显示值测试用例

* refactor: 重构测试用例分组,新增提示隐藏延迟常量

---------

Co-authored-by: lockiechen <290015551@qq.com>

* test(count-down): add count-down test (#697) (#781)

* test(count-down): add count-down test (#697)

* test(CountDown): 修复报错信息 (#697)

* test: update test case name

---------

Co-authored-by: novlan1 <1576271227@qq.com>

* feat(Message): add unit test and fix problems (#779)

* feat(Message): add unit test and fix problems

* chore: test

* feat(message): support object type of link

* test(message): 提升覆盖率

* test: 提升覆盖率

---------

Co-authored-by: novlan1 <1576271227@qq.com>

* feat(icon): upgrade icon 0.6.x (#785)

* feat(icon): upgrade icon 0.4.x

* chore: update snapshot

* fix(site): repair document rendering failed

* feat(Icon): update demo

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: anlyyao <anly_yaw@163.com>

---------

Co-authored-by: liweijie0812 <674416404@qq.com>
Co-authored-by: PiePie <45820630+ImaginingMaker@users.noreply.github.com>
Co-authored-by: Cyrios <995055954@qq.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: xliudaxia <xliudaxia@users.noreply.github.com>
Co-authored-by: JustGenius-s <53108645+JustGenius-s@users.noreply.github.com>
Co-authored-by: 阿菜 Cai <jimmyrss1102@gmail.com>
Co-authored-by: Yunqi Bai <byq1213@qq.com>
Co-authored-by: Boomkaa <48501916+Boomkaa@users.noreply.github.com>
Co-authored-by: Saraph1nes <52569690+Saraph1nes@users.noreply.github.com>
Co-authored-by: Lime_omie <128479982+MeoRinLime@users.noreply.github.com>
Co-authored-by: lockiechen <33082528+lockiechen@users.noreply.github.com>
Co-authored-by: lockiechen <290015551@qq.com>
Co-authored-by: SinzoL <113221060+SinzoL@users.noreply.github.com>
Co-authored-by: novlan1 <1576271227@qq.com>
Co-authored-by: julian <42023571+vancece@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Oct 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants