New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

基于wasm3增加基础的wasm能力 #1308

Merged

chexiongsheng merged 2 commits into Tencent:master from Tangxinwei:20230427

Apr 28, 2023

Contributor

Tangxinwei commented Apr 28, 2023

No description provided.

Tangxinwei added 2 commits

April 28, 2023 11:25


          基于wasm3，增加wasm的基础功能

4fe7837


          漏掉了h和hpp的格式化

ce94bf2

chexiongsheng merged commit 4b80213 into Tencent:master

Collaborator

chexiongsheng commented May 4, 2023

两点建议

1、建议wasm到js导出的api最好按WebAssembly JavaScript API标准来；
2、我看你搞了一套静态绑定，建议重用puerts的，puerts的静态绑定设计时就考虑过多种环境适配，比如现在就实现了两种环境的适配：
https://github.com/Tencent/puerts/blob/master/unreal/Puerts/Source/JsEnv/Public/V8Converter.hpp
https://github.com/Tencent/puerts/blob/master/unreal/Puerts/Source/JsEnv/Public/PesapiConverter.hpp
适配只要定义原生数据和虚拟机数据的交换即可。

Tangxinwei deleted the 20230427 branch

May 20, 2023 09:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet