Replace vmlaq_f32 with vfmaq_f32 (fused version) #6237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6237 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 836 836
Lines 264899 264899
=======================================
Hits 254098 254098
Misses 10801 10801 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nihui
requested changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vfmaq_f32 intrinsic compiles to the FMLA instruction which is more performant than separate
fmul+faddinstructions that vmlaq_f32 compiles to on latest GCC versions: https://godbolt.org/z/aYc9as5Wh