feat(sanitizer): remove jsdom from browser builds & add new commonjs …

…bundle for node env

build/rollup.base.config.js

@@ -26,6 +26,24 @@ import envReplacePlugin from './env';
 
 const IS_PRODUCTION = process.env.NODE_ENV === 'production';
 const PROJECT_ROOT_PATH = path.resolve(__dirname, '..');
+/** 构建目标是否 node */
+const IS_COMMONJS_BUILD = process.env.BUILD_TARGET === 'commonjs';
+
+const aliasPluginOptions = {
+  entries: [
+    {
+      find: '@',
+      replacement: path.resolve(PROJECT_ROOT_PATH, 'src'),
+    },
+  ],
+};
+
+if (IS_COMMONJS_BUILD) {
+  aliasPluginOptions.entries.unshift({
+    find: '@/Sanitizer',
+    replacement: path.resolve(PROJECT_ROOT_PATH, 'src', 'Sanitizer.node.js'),
+  });
+}
 
 export default {
   input: 'src/index.js',
@@ -40,14 +58,7 @@ export default {
     }),
     json(),
     envReplacePlugin(),
-    alias({
-      entries: [
-        {
-          find: '@',
-          replacement: path.resolve(PROJECT_ROOT_PATH, 'src'),
-        },
-      ],
-    }),
+    alias(aliasPluginOptions),
     resolve({
       ignoreGlobal: false,
       browser: true,

build/rollup.core.config.js

@@ -48,4 +48,15 @@ if (!Array.isArray(options.external)) {
 }
 options.external.push('mermaid');
 
+/** 构建目标是否 node */
+const IS_COMMONJS_BUILD = process.env.BUILD_TARGET === 'commonjs';
+
+if (IS_COMMONJS_BUILD) {
+  options.output = {
+    ...options.output,
+    file: options.output.file.replace(/\.js$/, '.common.js'),
+    format: 'cjs',
+  };
+}
+
 export default options;

build/rollup.engine.config.js

@@ -51,4 +51,15 @@ if (!Array.isArray(options.external)) {
 }
 options.external.push('mermaid');
 
+/** 构建目标是否 node */
+const IS_COMMONJS_BUILD = process.env.BUILD_TARGET === 'commonjs';
+
+if (IS_COMMONJS_BUILD) {
+  options.output = {
+    ...options.output,
+    file: options.output.file.replace(/\.js$/, '.common.js'),
+    format: 'cjs',
+  };
+}
+
 export default options;

package.json

@@ -27,11 +27,14 @@
   "scripts": {
     "iconfont": "gulp",
     "dev": "cross-env NODE_ENV=development rollup -w --config build/dev.js",
-    "build": "run-s clean build:all",
+    "build": "run-s clean build:all build:cjs",
     "build:all": "run-p iconfont build:types build:addons build:full build:debug build:core build:engine",
+    "build:cjs": "run-p build:core-cjs build:engine-cjs",
     "build:full": "cross-env NODE_ENV=production rollup --config build/build.js",
     "build:core": "cross-env CORE_BUILD=true NODE_ENV=production rollup --config build/rollup.core.config.js",
+    "build:core-cjs": "cross-env BUILD_TARGET=commonjs CORE_BUILD=true NODE_ENV=production rollup --config build/rollup.core.config.js",
     "build:engine": "cross-env CORE_BUILD=true NODE_ENV=production rollup --config build/rollup.engine.config.js",
+    "build:engine-cjs": "cross-env BUILD_TARGET=commonjs CORE_BUILD=true NODE_ENV=production rollup --config build/rollup.engine.config.js",
     "build:debug": "cross-env NODE_ENV=development HOT_RELOAD=false rollup --config build/dev.js",
     "build:addons": "tsc --project tsconfig.addons.json",
     "build:types": "tsc --project tsconfig.json",

src/Sanitizer.js

@@ -0,0 +1,4 @@
+import createDOMPurify from 'dompurify';
+
+// for browser
+export const sanitizer = createDOMPurify(window);

src/Sanitizer.node.js

@@ -0,0 +1,7 @@
+import createDOMPurify from 'dompurify';
+import { JSDOM } from 'jsdom';
+
+const { window } = new JSDOM('');
+
+// @ts-expect-error
+export const sanitizer = createDOMPurify(window);

src/core/HookCenter.js

@@ -164,7 +164,7 @@ export default class HookCenter {
       }
     } else {
       hookName = /** @type {typeof SyntaxBase}*/ (HookClass).HOOK_NAME;
-      const config = syntax[hookName] ? syntax[hookName] : customSyntax[hookName] ? customSyntax[hookName] : {};
+      const config = syntax[hookName] || customSyntax[hookName] || {};
       instance = new /** @type {typeof SyntaxBase}*/ (HookClass)({ externals, config, globalConfig: engine.global });
     }
     // Skip Internal Hook

src/core/hooks/HtmlBlock.js

@@ -14,25 +14,15 @@
  * limitations under the License.
  */
 import ParagraphBase from '@/core/ParagraphBase';
-import createDOMPurify from 'dompurify';
 import {
   whiteList,
   convertHTMLNumberToName,
   // isValidScheme, encodeURIOnce,
   escapeHTMLEntitiesWithoutSemicolon,
 } from '@/utils/sanitize';
-import { JSDOM } from 'jsdom';
+import { sanitizer } from '@/Sanitizer';
 import { isBrowser } from '@/utils/env';
 
-let sanitizer;
-
-if (isBrowser()) {
-  sanitizer = createDOMPurify(window);
-} else {
-  const { window } = new JSDOM('');
-  sanitizer = createDOMPurify(/** @type {any} */ (window));
-}
-
 export default class HtmlBlock extends ParagraphBase {
   static HOOK_NAME = 'htmlBlock';
   constructor() {