fix(datasource): support Yuque team token in connector#1477
Open
Once-the-sea-was-difficult-for-water wants to merge 1 commit into
Open
Conversation
- Add Type field to v2User struct to distinguish personal/team tokens - Route team tokens directly to ListGroupRepos (skip ListUserGroups) - Gracefully handle ListUserGroups 404 for personal tokens without teams - Add rate-limiting delay between GetDocDetail calls to avoid API throttling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using a Yuque team token, the connector calls
GET /api/v2/users/{id}/groupswhich returns 404 because a team entity is not a user. This causesListResourcesto fail entirely, blocking data source setup.Additionally, personal tokens without any team memberships also trigger 404 (Yuque returns 404 instead of an empty list), causing the same fatal error.
This PR:
Typefield tov2Userstruct to detect token type ("User" vs "Group")ListGroupRepos, skippingListUserGroupsListUserGroups404 for personal tokens without teams (warn + fallback to empty)GetDocDetailcalls to prevent Yuque API rate limiting (429)Type of Change
Related Issue
N/A
Testing
ListResourcesreturns team knowledge bases successfully (previously returned 404)Checklist
make fmt && make lint && make testpass locallydocs/, Swagger annotations, etc.)Screenshots / Recordings
N/A (backend-only change, no UI impact)