[TOOLS][ADD] Model checker support Huawei NPU#684
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #684 +/- ##
==========================================
+ Coverage 33.00% 33.28% +0.28%
==========================================
Files 288 298 +10
Lines 8472 8814 +342
==========================================
+ Hits 2796 2934 +138
- Misses 5676 5880 +204
Continue to review full report at Codecov.
|
seanxcwang
reviewed
Dec 31, 2020
Comment on lines
+107
to
+108
| *sub_network_interp_->GetNetStructure() = *default_interpreter->GetNetStructure(); | ||
| *sub_network_interp_->GetNetResource() = *default_interpreter->GetNetResource(); |
Collaborator
There was a problem hiding this comment.
直接对一个对象的私有成员变量赋值，感觉不太像一个规范的做法
seanxcwang
reviewed
Dec 31, 2020
| "OPENCL, METAL, ARM, CUDA\n" | ||
| "\t-i, --input \t(optional) input file\n" | ||
| "\t-o, --output \t(optional) dump output\n" | ||
| "\t-c, --cmp_o \t(optional) compare output only\n" |
Collaborator
There was a problem hiding this comment.
这个参数感觉有点奇怪，有点意义不明，在前面的很多脚本中，-c 都是clean的意思
seanxcwang
reviewed
Dec 31, 2020
Comment on lines
+68
to
+69
| bool CompareData(void* device_data, void* cpu_data, DimsVector blob_dims); | ||
| void DumpBlobData(void* blob_data, DimsVector blob_dims, | ||
| std::string output_name); | ||
| bool CompareDiffCosDistance(void* device_data, void* cpu_data, DimsVector blob_dims); |
Collaborator
There was a problem hiding this comment.
这个两个接口的参数完全一样，是不是可以通过增加一个compare_type的参数，不然后面如果有个MSE的方式，又得加一个接口
seanxcwang
approved these changes
Dec 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.