Implement Mozilla WebExtension best practices and fix background script issues#21
Merged
Implement Mozilla WebExtension best practices and fix background script issues#21
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: TenSoja <1338661+TenSoja@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Instructions for the Copilot Coding Agent in this Firefox addon repository
Implement Mozilla WebExtension best practices and fix background script issues
Aug 23, 2025
TenSoja
approved these changes
Aug 23, 2025
Owner
TenSoja
left a comment
There was a problem hiding this comment.
Approved!
Great job fixing the background script and upgrading the documentation.
This PR officially passes the “Copilot-bot review”... and just like a good Firefox extension, it didn’t crash under pressure!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Mozilla's WebExtension development best practices and fixes a critical issue in the background script that prevented proper functionality.
Key Changes
Fixed Critical Background Script Issue
The background script was incorrectly using
window.addEventListenerto handle keyboard events, which doesn't work in WebExtension background contexts. Background scripts don't have access to the DOMwindowobject. This functionality was already properly implemented via the manifest.jsoncommandssection, so the broken code has been removed:Enhanced Documentation
Completely rewrote the README.md to include:
Mozilla Best Practices Compliance
browsingData,notifications,storage)Code Quality Improvements
customKeysetting from default configurationonErrorfunctionsThe extension now fully complies with Mozilla's development standards and the keyboard shortcut (F9) works correctly through the proper WebExtension commands API.
Fixes #20.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.