Skip to content
This repository has been archived by the owner on Dec 5, 2019. It is now read-only.

Don't start a new webserver after a crash if one is still running #223

Closed
EddyVerbruggen opened this issue Feb 14, 2016 · 2 comments
Closed

Don't start a new webserver after a crash if one is still running #223

EddyVerbruggen opened this issue Feb 14, 2016 · 2 comments

Comments

@EddyVerbruggen
Copy link
Contributor

I don't know if the webserver crashes as well after a webview crash, but if it doesn't a new webserver will be started on a different port. Since WKWebView ties LS to a port this means LS is lost during this session.

I'll add a guard to make sure if a webserver is still running it won't start a new one upon crash.
@devgeeks
Copy link

👍

EddyVerbruggen added a commit that referenced this issue Feb 14, 2016
@EddyVerbruggen
#223 Don't start a new webserver after a crash if one is still running
4f83a17
@EddyVerbruggen
Copy link
Contributor Author

Available in 0.6.9. Can't test it in case of a crash, but it works as expected when "simulating" it.

@kristfal kristfal mentioned this issue Jun 7, 2016
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@devgeeks @EddyVerbruggen