Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes UIWebView #185

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

josh-m-sharpe
Copy link

No description provided.

@ulisesvera
Copy link

Hi @josh-m-sharpe, did you solve UIWebView error for App Store apps submissions? I've tried your github folk but I get an error when I try to add the plugin.

@josh-m-sharpe
Copy link
Author

this removes the warning about using deprecated APIs

@tlacroix
Copy link

tlacroix commented May 5, 2020

Hi guys,

I didn't see this PR and ended up patching myself.

Since this project isn't maintained anymore, I forked it, patched it for ITMS-90809, and removed Windows Phone support. Patch is tested and working, and Apple now accepts my uploads.

Feel free to get in touch if you'd like to contribute.

https://github.com/tlacroix/NativePageTransitions
https://www.npmjs.com/package/cordova-plugin-nativepagetransitions

@josh-m-sharpe
Copy link
Author

Heya @tlacroix - thanks for doing that, I'll give your fork a try next time!

Question for you though... do you have your fork deployed on Android? Asking because I saw some problems there and had to revert adding this plugin as I didn't have time to dig into it. (Unfortunately, I don't have error/stack traces right now)

@tlacroix
Copy link

tlacroix commented May 6, 2020

Hi @josh-m-sharpe,

Yes, I have it running on two projects using cordova-ios 5.1.1 and cordova-android 7.1.4 (one on the app stores, one on TestFlight/Google Play Internal Testing Track), and a third one that isn't ITMS-90809 ready yet but getting there (still running old cordova-ios 4.5.4 + cordova-android 6.4.0)

This being said, removing the Telerik plugin is a pain. It took me about an hour each time to uninstall it, then remove all references to it in all the files (config.xml, package.json, package-lock.json, plugins/fetch.json, etc.) before I could then successfully install my fork. But once it's done, it works like a charm, on my side anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants