Skip to content

fix: on iOS requestReadPermission returns an invalid result before us… #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: on iOS requestReadPermission returns an invalid result before us… #242

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4af885
fix: on iOS requestReadPermission returns an invalid result before us…
sjregan Feb 4, 2021
355195c
fix: success callback not passing return value
sjregan Feb 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions src/ios/SOSPicker.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ - (void) requestReadPermission:(CDVInvokedUrlCommand *)command {
if (status == PHAuthorizationStatusAuthorized) {
NSLog(@"Access has been granted.");

CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsBool:true];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
} else if (status == PHAuthorizationStatusDenied) {
NSString* message = @"Access has been denied. Change your setting > this app > Photo enable";
Expand All @@ -49,11 +49,27 @@ - (void) requestReadPermission:(CDVInvokedUrlCommand *)command {
CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:message];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
} else if (status == PHAuthorizationStatusNotDetermined) {
// Access has not been determined. requestAuthorization: is available
[PHPhotoLibrary requestAuthorization:^(PHAuthorizationStatus status) {}];

CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
// Access has not been determined. requestAuthorization: is available, ask.
[PHPhotoLibrary requestAuthorization:^(PHAuthorizationStatus status) {
if (status == PHAuthorizationStatusAuthorized) {
NSLog(@"Access has been granted.");

CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK messageAsBool:true];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
} else if (status == PHAuthorizationStatusDenied) {
NSString* message = @"Access has been denied. Change your setting > this app > Photo enable";
NSLog(@"%@", message);

CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:message];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
} else if (status == PHAuthorizationStatusRestricted) {
NSString* message = @"Access has been restricted. Change your setting > Privacy > Photo enable";
NSLog(@"%@", message);

CDVPluginResult* pluginResult = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR messageAsString:message];
[self.commandDelegate sendPluginResult:pluginResult callbackId:command.callbackId];
}
}];
} else if (status == PHAuthorizationStatusRestricted) {
NSString* message = @"Access has been restricted. Change your setting > Privacy > Photo enable";
NSLog(@"%@", message);
Expand Down