Skip to content

Conversation

@Jeehut
Copy link
Contributor

@Jeehut Jeehut commented Jan 2, 2025

This implements the first 3 Pirate Metrics subtasks:

Note that I have expanded upon the requested dayOfWeek, dayOfMonth, and dayOfYear fields and ended up with the following fields (the requirements comment was updated):

  • TelemetryDeck.Calendar.dayOfWeek - Integer from 1 (Monday) to 7 (Sunday)
  • TelemetryDeck.Calendar.dayOfMonth - Integer from 1 to 31, representing the day of the month
  • TelemetryDeck.Calendar.dayOfYear - Integer from 1 to 366 (accounting for leap years), representing the day of the year
  • TelemetryDeck.Calendar.weekOfYear - Integer from 1 to 53, representing the week of the year
  • TelemetryDeck.Calendar.monthOfYear - Integer from 1 to 12, representing the month
  • TelemetryDeck.Calendar.quarterOfYear - Integer from 1 to 4, representing the quarter
  • TelemetryDeck.Calendar.hourOfDay - Integer from 1 to 24, representing the hour
  • TelemetryDeck.Calendar.isWeekend - Bool, true if Saturday or Sunday, false otherwise

All parameters use the Gregorian calendar and return -1 if the value cannot be calculated.

This PR is merge-ready as it targets the feature/pirate-metrics branch (which is 🚧 until all sub-tasks done).

@Jeehut Jeehut requested a review from winsmith January 2, 2025 14:35
Copy link
Contributor

@winsmith winsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@Jeehut Jeehut merged commit 2703fc6 into feature/pirate-metrics Jan 14, 2025
@Jeehut Jeehut deleted the feature/pm-persist-sessions branch January 14, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants