-
Notifications
You must be signed in to change notification settings - Fork 143
Added: support sasl/scram authentication #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🎉 , looks good to me. Let's see if @jpfe-tid wants to add something else, otherwise I'll merge it and release a new version in a couple of days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, @mingqing ! 🚀
I've added some rewrite suggestions to avoid conflicts in config.
Is it necessary to main.go "traefik/log" in is replaced by "logrus"? @jpfe-tid |
@mingqing thanks for noticing, we'll fix it by using only one logging package in the next PR (WIP), meantime we'll merge this PR. |
kafka client connect broker support SASL/SCRAM-* authentication, for example: