Always declare locals as mutable in derived impls #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Values for fields are kept in local variables prior to construction in
the
From*
derivations. Before #177, these local variables would beimmutable, since nothing would ever modify them. However, now the
generated code will mutate the local variable to insert the result of
a
from_none
call to the child. Therefore, for simplicity the variablesare always emitted as mutable.
Fixes #183