Fix unused keys in https://appleid.apple.com/auth/keys leading to invalid signatures#9
Open
codlab wants to merge 2 commits intoTechofficer:masterfrom
Open
Fix unused keys in https://appleid.apple.com/auth/keys leading to invalid signatures#9codlab wants to merge 2 commits intoTechofficer:masterfrom
codlab wants to merge 2 commits intoTechofficer:masterfrom
Conversation
|
Hi codlab, thanks for the work. I also got an issue in production. I did the fix on my side, I think the best way is to move from https://developer.apple.com/documentation/signinwithapplerestapi/jwkset/keys I did the same implementation mentionned in this link https://auth0.com/blog/implement-sign-in-with-apple-using-auth0-extensibility/ I can do the PR if you agree |
tomislavherman
added a commit
to tomislavherman/node-apple-signin
that referenced
this pull request
Feb 17, 2020
…e json from response
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on fixing the invalid signature when dealing with jwt token signed by the non 0 index key of https://appleid.apple.com/auth/keys