HEEDLS-553 Date Input Validation #497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…validation in WelcomeEmail VM New DateValidator class will replace existing DateValidator class
Keep this helper class around for existing usage in Learning Portal (to be refactored later in 560)
…g to create Date object
…cept custom css; fix bug
… dates Also remove an unneeded year check which resulted in a potentially confusing error message
Contributor
DanBloxham-sw
left a comment
DanBloxham-sw
left a comment
There was a problem hiding this comment.
Few minor comments, but pretty good overall.
DigitalLearningSolutions.Web/Views/Shared/Components/DateInput/Default.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ViewComponents/DateInputViewComponent.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ControllerHelpers/DateValidator.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ControllerHelpers/DateValidator.cs
Outdated
Show resolved
Hide resolved
DanBloxham-sw
approved these changes
Jul 22, 2021
stellake
reviewed
Jul 22, 2021
Contributor
stellake
left a comment
stellake
left a comment
There was a problem hiding this comment.
Would be good to share this at knowledge sharing next week so the team is aware of the existence of this component 👍
DigitalLearningSolutions.Web.Tests/ControllerHelpers/DateValidatorTests.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ControllerHelpers/DateValidator.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ControllerHelpers/DateValidator.cs
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web/ViewModels/Register/RegisterDelegateByCentre/WelcomeEmailViewModel.cs
Outdated
Show resolved
Hide resolved
...lLearningSolutions.Web/ViewModels/Register/RegisterDelegateByCentre/WelcomeEmailViewModel.cs
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/ControllerHelpers/DateValidator.cs
Outdated
Show resolved
Hide resolved
…d values in dates
…d comment about duplicate error messages
stellake
reviewed
Jul 23, 2021
DigitalLearningSolutions.Web.Tests/ControllerHelpers/DateValidatorTests.cs
Show resolved
Hide resolved
stellake
added a commit
that referenced
this pull request
Jul 23, 2021
…S-553-date-input-validation" This reverts commit 210a193.
ibrahimmunir14
pushed a commit
that referenced
this pull request
Jul 26, 2021
…ng/HEEDLS-553-date-input-validation"" This reverts commit 8753fb7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored/rewrote/tidied up DateValidator, DateInputVC, and WelcomeEmail. Date input errors are now model state errors, compatible with error summary and treated in a similar way to normal text input errors. Errors are identified and indicated correctly. Error messages are more appropriate and correct.