HEEDLS-430 - Implemented basic centre course setup page #472
Conversation
| <a class="nhsuk-button nhsuk-u-margin-right-2" role="button" | ||
| asp-controller="LearningMenu" asp-action="Index" asp-route-customisationId="@Model.CustomisationId"> | ||
| Launch course | ||
| </a> | ||
| <a class="nhsuk-button nhsuk-button--secondary " role="button" asp-controller="TopCourses" asp-action="Index"> | ||
| Manage course | ||
| </a> |
There was a problem hiding this comment.
One thing I've noticed when we have two buttons/links next to each other on the same row is that NVDA seems to read them together in one quick burst, and the second button cannot be highlighted/stopped on when just using the arrow keys. Tabbing works fine. I don't know if this is just specific to my set up of NVDA, but there is a setting in Browse Mode that fixes this that I've enabled.
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/_CentreCourseCard.cshtml
Show resolved
Hide resolved
AlexJacksonDS
left a comment
AlexJacksonDS
left a comment
There was a problem hiding this comment.
Some comments and questions. Definitely need to get latest master into the branch and sort out the css files used.
| <link rel="stylesheet" href="@Url.Content("~/css/shared/searchableElements.css")" asp-append-version="true"> | ||
| <link rel="stylesheet" href="@Url.Content("~/css/shared/cardWithButtons.css")" asp-append-version="true"> |
There was a problem hiding this comment.
The seachableElements css file has moved on latest master post 532 merge.
We are also trying to start setting up the scss a bit better, this means we should probably be defining a courseSetup.scss that imports these 2 css files instead. Then we just have to include 1 file. See what I've done with centreAdministrators.scss for an example.
DigitalLearningSolutions.Web/Controllers/TrackingSystem/CourseSetup/CourseSetupController.cs
Show resolved
Hide resolved
| Courses = courses; | ||
| } | ||
|
|
||
| public IEnumerable<CourseStatistics> Courses { get; set; } |
There was a problem hiding this comment.
If this is going to be a page with search/sort/filter in the future (like the wireframes suggest), this is going to need a separate view model rather than using the database entity. Doesn't necessarily need to change now, but it will likely need changing in the future
DigitalLearningSolutions.Web.AutomatedUiTests/AccessibilityTests/BasicAccessibilityTests.cs
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/_CentreCourseCard.cshtml
Outdated
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/_CentreCourseCard.cshtml
Show resolved
Hide resolved
DigitalLearningSolutions.Web/Views/TrackingSystem/CourseSetup/_CentreCourseCard.cshtml
Outdated
Show resolved
Hide resolved
Ran all unit tests. Tested in Chrome, Edge, Firefox, IE. Tested with mobile/zoom, screen reader.
Desktop view:
Mobile view: