TD-5401 manage supervision settings #3431
Conversation
…/Features/TD-5401-Managesupervisionsettings
…esupervisionsettings
kevwhitt-hee
left a comment
kevwhitt-hee
left a comment
There was a problem hiding this comment.
Thanks @sherif-olaboye. I have made a couple of inline comments. In addition, if we are moving the default declaration text values to appsettings, then we should read them from appsettings into the view where they are presented to learners and supervisors. Please could we make this change?
| "ReadOnlyConnection": "Data Source=localhost;Initial Catalog=mbdbx101_uar;Integrated Security=True;encrypt=false;TrustServerCertificate=true;", | ||
| "UnitTestConnection": "Data Source=localhost;Initial Catalog=mbdbx101_uar_test;Integrated Security=True;encrypt=false;TrustServerCertificate=true;" | ||
| }, | ||
| "LearnerDefaultText": "<p>I confirm that I have completed the required pathway and achieved the necessary {{CompetencyAssessmentName}}. I understand that:</p><ul> <li>I am responsible and accountable for my practice</li><li>my skills and achievements are recorded for future reference</li><li>if I move to a new role or area, I may need to review or expand my skills</li><li>I must follow organisational policies and guidance</li><li>I should speak to a senior colleague if I am unsure about any aspect of my practice,</li></ul><p>my {{CompetencyAssessmentName}} will be reviewed as part of personal development and revalidation</p>", |
There was a problem hiding this comment.
Since the value is the same for all environments. This should only be set here, in this file - the other environment appsettings files where it is set are unnecessary - they would only be used to override this with environment-specific values.
There was a problem hiding this comment.
Since the value is the same for all environments. This should only be set here, in this file - the other environment appsettings files where it is set are unnecessary - they would only be used to override this with environment-specific values.
Done
| </label> | ||
| <nhs-form-group nhs-validation-for="CustomText"> | ||
|
|
||
| <textarea class="nhsuk-textarea" id="custom-declaration-text" name="CustomText" rows="5" aria-describedby="custom-declaration-hint">@Model.CustomText</textarea> |
There was a problem hiding this comment.
We should use Jodit to turn this into a html input and then sanitise before storing.
There was a problem hiding this comment.
We should use Jodit to turn this into a html input and then sanitise before storing.
Done
…enviroment specific appsetting
…esupervisionsettings
JIRA link
https://hee-tis.atlassian.net/browse/TD-5401
Description
Renamed Action: The SupervisorRoles action method was renamed to Manage supervision settings on the competency assessment task list.
Added New Views/Pages and Functionality:
Supervised Self-Assessment: Introduced the Supervised self assessment view with an associated sign-off action method and logic.
Supervisor Sign-Off: Created the Supervisor sign off declaration view with its corresponding sign-off action method and logic.
Learner Sign-Off: Implemented the Learner sign off declaration view with its corresponding sign-off action method and logic.
Supervision Settings Management: Added the Manage supervision settings view with an associated sign-off action method and logic.
You introduced several new classes to support the data structure and interaction logic for the new sign-off pages:
Base Model: Added the abstract or base class BaseSignoffDeclarationViewModel.
Specific Sign-Off Models:
SupervisedSelfAssessmentSignoffViewModel
LearnerSignoffDeclarationViewModel
SupervisorSignoffDeclarationViewModel
Management Model: Added the view model ManagesupervisionViewModel.
Application Settings: Updated the appsettings configuration file to include default statements for both the learner and supervisor sign-off declarations.
Screenshots
Supervised self assessment and sign-off page
Supervisor sign off declaration page
Learner sign off declaration page
Manage supervision settings page
Task list
Developer checks
(Leave tasks unticked if they haven't been appropriate for your ticket.)
I have:
Either:
Or: