Skip to content

Conversation

@manishagarwalnhs
Copy link
Contributor

JIRA link

HEEDLS-XXXX

Description

Deleting a competency with a flag was throwing an exception because of a foreign key violation. The issue is fixed.

Screenshots

No Screenshots. The steps are defined in the jira item; https://hee-dls.atlassian.net/browse/DLSV2-577


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • [X ] Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • [ X] Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee merged commit 1f6bea4 into master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants