Skip to content

Conversation

@SteveJacksonSoft
Copy link
Contributor

@SteveJacksonSoft SteveJacksonSoft commented Aug 25, 2022

JIRA link

HEEDLS-1036

Description

Bug fix: When resources were being added to an action plan, an entity was being added to CandidateAssessmentLearningLogItems with the self assessment id as the FK to CandidateAssessments. This was wrong: it should have been the candidate assessment id.

Screenshots

N/A


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have:

  • Run the formatter and made sure there are no IDE errors.
  • Written tests for the changes (accessibility tests, unit tests for controller, data services, services, view models, etc)
  • Manually tested my work with and without JavaScript. Full manual testing guidelines can be found here: https://softwiretech.atlassian.net/wiki/spaces/HEE/pages/6703648740/Testing
  • Updated/added documentation in Swiki and/or Readme. Links (if any) are below:
  • Updated my Jira ticket with information about other parts of the system that were touched as part of the MR and have to be sanity tested to ensure nothing’s broken.
  • Scanned over my own MR to ensure everything is as expected.

@kevwhitt-hee kevwhitt-hee merged commit 6602be3 into master Aug 25, 2022
@kevwhitt-hee kevwhitt-hee deleted the HEEDLS-1036-use-correct-id-when-adding-learning-log-item branch August 25, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants