[#308] 🦺 Maven Enforcer Rule for uv version #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-ryan-ashcraft
commented
Mar 26, 2025
There was a problem hiding this comment.
I (Informational): pulled up common code with some refactoring to have a common base for checking tool versions.
There was a problem hiding this comment.
I: some minor sonarlint cleanup
d-ryan-ashcraft
force-pushed
the
308-uv-enforcer-rule
branch
from
dc257af to
9f0bb73
Compare
d-ryan-ashcraft
commented
Mar 26, 2025
| @@ -50,6 +50,19 @@ | |||
| </rules> | |||
| </configuration> | |||
| </execution> | |||
There was a problem hiding this comment.
I: we'll flow a follow on to reorg the examples, so that:
examplespoetry(will have poerty enforcer config to isolate it to poetry examples)- rename for consistency to
habushu-poetry-XYZ
- rename for consistency to
uv(will have uv enforcer config to isolate it to uv examples)- rename for consistency to
habushu-uv-XYZ
- rename for consistency to
If needed, we'll add a general folder for habushu items that aren't specific to poetry or uv as well. There is a lot of churn with that, so wanted it in a separate, focused ticket for clarity in the intent and PR
chang-annie
approved these changes
Mar 26, 2025
...gin/src/main/java/org/technologybrewery/habushu/enforcer/AbstractRequireToolVersionRule.java
Outdated
Show resolved
Hide resolved
carter-cundiff
approved these changes
Mar 26, 2025
d-ryan-ashcraft
force-pushed
the
308-uv-enforcer-rule
branch
from
9f0bb73 to
c60fd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.