feature: new params for graphviz + solves #70 #74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- solve abs path bug Technologicat#70 - new params for graphviz (ranksep; layout) - tested layout `dot`; `fdp` (square graph) - updated `.gitignore` (files gen. after `visualize_pyan_architecture.sh`)
Owner
Technologicat
left a comment
Technologicat
left a comment
There was a problem hiding this comment.
Looks good to me.
@jdb78 : anything to add?
Collaborator
|
@maciejczyzewski Could you give your consent to relicense your contributions under the MIT and BSD licences here: #68? And: I think the readme changes for you to |
Author
|
Yeah, sure 😄 (already commented in #68) I switched to Edit: |
|
@Technologicat @jdb78 FWIW I have used this branch successfully on a moderately complex project, and it works as expected. |
joenio
added a commit
to analizo/pyan
that referenced
this pull request
Nov 9, 2024
The code included in this commit was adapted from the implementation on the Pull-Request Technologicat#74 made by the author @maciejczyzewski Resolves: Technologicat#70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
solve abs path bug Pyan crashes when i give filename or don't give #70
new params for graphviz (
--dot-ranksep 5-> ranksep;--graphviz-layout fdp-> layout)when working with
--htmland someone wants more space or zoom capacity, ranksep is helpfultested layout param on various projects:
dot(default);fdp(square graph);but every layout that is documented in: https://graphviz.org/documentation/#layout-manual-pages works.
updated
.gitignore(files gen. aftervisualize_pyan_architecture.sh)Example (
--graphviz-layout fdp):