-
Notifications
You must be signed in to change notification settings - Fork 71
Migrate to UV from setup tools. #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Great, thanks! That was quick :) Reviewed. Mostly looks good to me. Just two questions/comments:
Otherwise, looks great. |
|
Thanks for the quick review. :) for the test script, I've forgot to add it, so I've added and updated in latest patch. Thanks for the valuable insights, appreciating for your time to explaining. Thanks & Regards, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed.
Two more small things, in the new test script.
Other files already OK.
EDIT: Ah, does uv.lock need to be in version control?
|
Tests with 3.11 uv run python -m pytest tests -q tests/test_analyzer.py::test_resolve_import_as PASSED [ 16%] =============================================================================== tests coverage =============================================================================== Name Stmts Miss Cover Missing pyan/init.py 46 33 28% 11-20, 77-119 pyan/main.py 3 3 0% 3-6 pyan/analyzer.py 776 263 66% 100, 125-137, 188, 194, 206, 222-225, 255-268, 286-330, 384-386, 466, 470-475, 498, 500, 502, 512-516, 518-523, 611, 649-652, 657-660, 738, 752, 773-789, 794-809, 819-828, 831, 834-835, 838-839, 842-843, 846-847, 859-885, 894, 899-900, 903-909, 929-934, 939-979, 995, 1001-1005, 1013, 1015, 1082-1086, 1106, 1112-1138, 1141-1153, 1170, 1185-1190, 1204-1219, 1275, 1320-1324, 1342-1344, 1365, 1367, 1381, 1399-1406, 1419, 1421, 1424, 1434, 1468, 1501-1505, 1601, 1604, 1650, 1655-1657, 1691-1693, 1696-1697, 1703-1705, 1708-1709, 1714, 1733-1738, 1741-1742, 1745, 1758-1764 pyan/anutils.py 162 79 51% 13-14, 18-21, 43, 63, 93, 114-122, 125, 128, 131-143, 157-166, 174-200, 244-245, 252-263, 267-287 pyan/main.py 81 72 11% 23-243, 247 pyan/sphinx.py 64 64 0% 27-167 pyan/visgraph.py 149 128 14% 23-28, 31-36, 39-43, 46-47, 50-63, 67-72, 81-86, 89-93, 104-107, 110, 115-120, 124-251 pyan/writers.py 233 185 21% 17-21, 24, 27, 30, 33, 36-49, 52-57, 60-63, 66, 69, 72, 75, 78, 81, 84, 87, 92-94, 97-99, 102, 105-106, 111-116, 119-121, 124-131, 134-137, 140-141, 147-153, 156, 162-181, 186-206, 211-214, 217-236, 239-265, 268-272, 275-293, 296-316, 319-322 TOTAL 1596 860 46% |
|
Merged. Thanks very much for the build system migration! The incompleteness of the existing automated tests is a good point. I opened an issue to track it, see #105. We can discuss improvements to the tests further there - I might have some ideas for what kinds of test cases we need. |
|
One more thing - it's a separate issue, but since I can reach you here - could you add a quick guide (a few lines) for developers who aren't familiar with UV, or a link to an existing quickstart guide somewhere on the internet? Particular questions I have:
For an example, see the install instructions I wrote for another open-source project that I'm currently building at work. EDIT: Or maybe even better, the development mode instructions I wrote for Doesn't need to be that long - I'm just inefficient at explaining things compactly. |
|
Hi, for tests, I agree and will continue on the new issue.
I've created a contribution doc and a simple util to get start with the uv cmds. Please review this PR #106 on your time let me know whether its useful or I can remove it, if its adding a more complexity. Please let me know, if anything can be improved as well. Thanks & Regards, |
|
Looks good. Merged. |
As part of making Pyan useful tool again, migrate the packaging tool to uv from setup tools.
Created a issue for the same: #103