Skip to content

Commit

Permalink
platform-drivers-x86: intel_pmic_gpio: Fix off-by-one valid offset ra…
Browse files Browse the repository at this point in the history
…nge check

Only pin 0-7 support input, so the valid offset range should be 0 ~ 7.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
  • Loading branch information
AxelLin authored and Matthew Garrett committed Jun 9, 2014
1 parent 963649d commit 21a3542
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/platform/x86/intel_pmic_gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ static void pmic_program_irqtype(int gpio, int type)

static int pmic_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
{
if (offset > 8) {
if (offset >= 8) {
pr_err("only pin 0-7 support input\n");
return -1;/* we only have 8 GPIO can use as input */
}
Expand Down Expand Up @@ -130,7 +130,7 @@ static int pmic_gpio_get(struct gpio_chip *chip, unsigned offset)
int ret;

/* we only have 8 GPIO pins we can use as input */
if (offset > 8)
if (offset >= 8)
return -EOPNOTSUPP;
ret = intel_scu_ipc_ioread8(GPIO0 + offset, &r);
if (ret < 0)
Expand Down

0 comments on commit 21a3542

Please sign in to comment.