-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather app - Elina Eriksson Hult #420
Open
ElinaEH
wants to merge
12
commits into
Technigo:master
Choose a base branch
from
ElinaEH:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIPPIEKICK
previously requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML/CSS
- Well-named class names and well-structured CSS. Short and sweet!
- The HTML file can benefit from some cleaning up though.
- Using
br
is a bit old school - remember that you can make use of spans, block elements and flexbox to achieve the same things - I know we talked about this but I'd really recommend breaking out the svg file to avoid cluttering the HTML file. Please reach out on Stack Overflow if you need help.
- Using
- Nice job trying to copy the design 😎
JavaScript
- Well-named variables in your JS file! Creating some functions would make the code even more readable and modular, so try to think about that going forward.
Clean Code
- Remove console.logs
Changes Requested
Clean up the HTML file, but apart from that - it looks super!
JennieDalgren
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://elinasweatherapp2.netlify.app/