Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weather app - Elina Eriksson Hult #420

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

ElinaEH
Copy link

@ElinaEH ElinaEH commented Sep 29, 2024

@HIPPIEKICK HIPPIEKICK self-assigned this Oct 3, 2024
Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML/CSS

  • Well-named class names and well-structured CSS. Short and sweet!
  • The HTML file can benefit from some cleaning up though.
    • Using br is a bit old school - remember that you can make use of spans, block elements and flexbox to achieve the same things
    • I know we talked about this but I'd really recommend breaking out the svg file to avoid cluttering the HTML file. Please reach out on Stack Overflow if you need help.
  • Nice job trying to copy the design 😎

JavaScript

  • Well-named variables in your JS file! Creating some functions would make the code even more readable and modular, so try to think about that going forward.

Clean Code

  • Remove console.logs

Changes Requested
Clean up the HTML file, but apart from that - it looks super!

Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants