Week 10 – To-do App – Kathinka & Nathalie #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kathinka Sewell <kathinka@users.noreply.github.com>
…d status - it works but should de refactored so it uses useContext correctly
…y - but it still has issues :( light styling as well - but it is ugly and temp so lets improve it
…f the text is too long also I adjustet the text so its optically in line with the checkbox.
…ser could change it
…askData and TaskMaker component styles. added local storage
AntonellaMorittu
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Hi Kathinka & Nathalie, well done this week with the Todo App! You pushed yourself to accomplish more and implement some stretch goals, awesome! The app comply with responsiveness, good use of updating global state with React Context, you also have your code tidy (I left a comment about one file to format), please check the sorting functionality, it's not there yet. Great you added moment.js and localStorage implementation. Give another check to accessibility, should score at least! Keep up the awesome work ⭐
There was a problem hiding this comment.
did you test this feature? The sorting is buggy - please test test test 🚀 and format the file too
… correctly. added a variable to store the original list in, and made sure it got updated on new entries, but not when the list where sorted, so the original order was kept.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://kathinkas-and-nathalies-task-master.netlify.app/
Collaborators
[kathinka]