Martin & Sofies Eggcellent Todo #14
Conversation
Co-authored-by: Sofie Ferrari Strahl <SofieFerrari@users.noreply.github.com>
Co-authored-by: Sofie Ferrari Strahl <SofieFerrari@users.noreply.github.com>
Co-authored-by: Sofie Ferrari Strahl <SofieFerrari@users.noreply.github.com>
There was a problem hiding this comment.
Hi Martin and Sofie, well done this week with the Todo App! It's a simple but perfectly working app, build meeting the requirements and following the good practices. Give another check to accessibility, should score at least 95 👍 Good use of updating global state with React Context, you also have your code tidy, I would only recommend to keep an eye on items alignment in the UI (icons perfectly aligned to text), also could be best to leave the column to the right visible even if no tasks are listed, simply have an empty state component displaying like "No tasks added". In this way the UI component will be rendered at loading and not added to the DOM when adding the task, makes the UI move a bit too much. Anyway, you nailed it. Keep up the good work ⭐
There was a problem hiding this comment.
are you using all the assets? Better delete the ones unused 🧹
Netlify link
https://eggcellent-todo.netlify.app/
Collaborators
[SofieFerrari]