Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jonas Portfolio #397

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Jonas Portfolio #397

wants to merge 9 commits into from

Conversation

Jonash189
Copy link

@JennieDalgren JennieDalgren self-assigned this Nov 7, 2024
Maryyy-ux
Maryyy-ux reviewed Nov 10, 2024
View reviewed changes
Copy link

@Maryyy-ux Maryyy-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jonas, awesome portfolio project, just left two constructive comments.

src/components/project/Project.css
align-items: center;
}

@media (min-width: 768px) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart media queries! Love that! Everything under control and defined. Congrats!

src/components/project/Project.jsx
@@ -0,0 +1,36 @@
import React from "react";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import React from "react";
import React from "react";

Oops, maybe this is a missing pillow. Seems its not required.

JennieDalgren
JennieDalgren requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the projects.

Almost got everything right. Make sure to go through the design again and check all sizes, paddings, widths and spacings.

image

This is an example on where your code differs too much from the design provided.

Keep up the good work! :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maryyy-ux Maryyy-ux Maryyy-ux left review comments

@JennieDalgren JennieDalgren JennieDalgren requested changes

Assignees

@JennieDalgren JennieDalgren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jonash189 @JennieDalgren @Maryyy-ux